Update CONFIG GET and CONFIG SET documentation and tests #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: Jonathan Louie <[email protected]>
…meters Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: Jonathan Louie <[email protected]>
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: jonathanl-bq <[email protected]>
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Jonathan Louie <[email protected]>
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Jonathan Louie <[email protected]>
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Jonathan Louie <[email protected]>
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
…le config error Signed-off-by: Jonathan Louie <[email protected]>
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Jonathan Louie <[email protected]>
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Yury-Fridlyand
approved these changes
Jan 8, 2025
node/tests/SharedTests.ts
Outdated
| async (protocol) => { | ||
| await runTest(async (client: BaseClient, cluster) => { | ||
| if (cluster.checkIfServerVersionLessThan("7.0.0")) { | ||
| return; |
There was a problem hiding this comment.
Optional: You can check that server returns an error on version < 7
tjzhang-BQ
approved these changes
Jan 9, 2025
Signed-off-by: Jonathan Louie <[email protected]>
Signed-off-by: Jonathan Louie <[email protected]>
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Jonathan Louie <[email protected]>
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
jonathanl-bq
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jonathanl-bq
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
jonathanl-bq
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
prateek-kumar-improving
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Update documentation for CONFIG GET and CONFIG SET commands for Java client Signed-off-by: Jonathan Louie <[email protected]> * Update documentation for BaseTransaction CONFIG GET and CONFIG SET Signed-off-by: Jonathan Louie <[email protected]> * Add transaction test for CONFIG SET and CONFIG GET with multiple parameters Signed-off-by: Jonathan Louie <[email protected]> * Update Python client CONFIG SET and CONFIG GET docs and tests Signed-off-by: Jonathan Louie <[email protected]> * Update Python transaction CONFIG GET and CONFIG SET docs Signed-off-by: Jonathan Louie <[email protected]> * Update Node client docs and tests for CONFIG SET and CONFIG GET Signed-off-by: Jonathan Louie <[email protected]> * Update CHANGELOG Signed-off-by: Jonathan Louie <[email protected]> * Fix linter issue Signed-off-by: Jonathan Louie <[email protected]> * Fix Prettier issues Signed-off-by: Jonathan Louie <[email protected]> * Apply Spotless Signed-off-by: Jonathan Louie <[email protected]> * Add missing cluster argument for Node SharedTests Signed-off-by: Jonathan Louie <[email protected]> * Try changing cluster-node-timeout instead of logfile to avoid immutable config error Signed-off-by: Jonathan Louie <[email protected]> * Fix test failures for Node client Signed-off-by: Jonathan Louie <[email protected]> * Fix linting errors Signed-off-by: Jonathan Louie <[email protected]> * Sort expected result for CONFIG GET and CONFIG SET transaction test Signed-off-by: Jonathan Louie <[email protected]> * Assign sorted array to new variable Signed-off-by: Jonathan Louie <[email protected]> * Apply Black linter Signed-off-by: Jonathan Louie <[email protected]> * Update Python tests to avoid immutable config error Signed-off-by: Jonathan Louie <[email protected]> * Apply Black linter Signed-off-by: Jonathan Louie <[email protected]> * Fix typo Signed-off-by: Jonathan Louie <[email protected]> * Fix typo in Python tests Signed-off-by: Jonathan Louie <[email protected]> * Run Black linter Signed-off-by: Jonathan Louie <[email protected]> * Fix failing Node test Signed-off-by: Jonathan Louie <[email protected]> * Remove swap file Signed-off-by: Jonathan Louie <[email protected]> * Combine CONFIG GET and CONFIG SET tests in SharedTests.ts Signed-off-by: Jonathan Louie <[email protected]> * Fix build error Signed-off-by: Jonathan Louie <[email protected]> --------- Signed-off-by: Jonathan Louie <[email protected]> Signed-off-by: jonathanl-bq <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2192
Checklist
Before submitting the PR make sure the following are checked: